VSCodeVim / VSCodeVim/Vim

Mark not set

Open
#7,504 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

To Reproduce
Steps to reproduce the behavior:

1 highlight some text in vscode
2 shift + ':'
3 's/'
errors on slash

VSCodeVim version: 1.22.1

Stack trace
Error: Mark not set
    at Function.fromCode (c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\src\error.ts:94:14)
    at c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\src\vimscript\lineRange.ts:152:28
    at h.resolve (c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\src\vimscript\lineRange.ts:126:18)
    at f.resolve (c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\src\vimscript\lineRange.ts:310:29)
    at l.allMatches (c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\src\vimscript\pattern.ts:82:34)
    at M.getSubstitutionDecorations (c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\src\cmd_line\commands\substitute.ts:267:30)
    at C.getDecorations (c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\src\cmd_line\commandLine.ts:253:22)
    at j.updateSearchHighlights (c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\src\mode\modeHandler.ts:1141:36)
    at j.updateView (c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\src\mode\modeHandler.ts:1545:49)
    at _ (c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\extensionBase.ts:54:22)
    at process.mh (internal/process/task_queues.js:93:5)
    at c:\Users\Joshua\.vscode\extensions\vscodevim.vim-1.22.1\extensionBase.ts:264:15

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/vimscript/lineRange.ts around line 152 and trace how the range is resolved from the substitution path in src/cmd_line/commands/substitute.ts. Reproduce the VSCode visual-selection workflow and inspect the command-line update path in src/cmd_line/commandLine.ts; done means the substitution no longer raises “Mark not set” for the reported steps.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
developer-experience
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.