Confusing (broken?) state after hitting enter in explorer filter
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
Stuck in confusing seemingly broken state after hitting enter after a filter in the explorer view.
To Reproduce
- begin filter in explorer view by typing
/while explorer is focussed - typing a search query e.g.
test - hitting enter leaves the explorer in a greyed out state
- I seem to only be able to exit this greyed out state by repeating enter, which leaves me editing the name of that file, then I hit enter again to be back in normal focus of the explorer.
Please see the attached demonstration.mov
Expected behavior
My expectation coming as a vim user is:
- type
/to begin filter - type in the search
- hit enter and I'm in the mode where
ngoes to the next selection as in vim's (:help /)
Screenshots
If applicable, add screenshots to help explain your problem.
If remapping-related, please attach log output: https://github.com/VSCodeVim/Vim#debugging-remappings.
Environment (please complete the following information):
- Extension (VsCodeVim) version: 1.21.5
- VSCode version: 1.55
- OS: max osx Big Sur 11.5.1
Additional context
Add any other context about the problem here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in the explorer view using the filter steps described, then trace how Enter is handled after entering a search. Confirm that Enter leaves the explorer in the expected navigation mode, where n selects the next match, rather than a greyed-out or file-renaming state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100