VSCodeVim / VSCodeVim/Vim

Confusing (broken?) state after hitting enter in explorer filter

Open
#7,017 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
Stuck in confusing seemingly broken state after hitting enter after a filter in the explorer view.

To Reproduce

  1. begin filter in explorer view by typing / while explorer is focussed
  2. typing a search query e.g. test
  3. hitting enter leaves the explorer in a greyed out state
  4. I seem to only be able to exit this greyed out state by repeating enter, which leaves me editing the name of that file, then I hit enter again to be back in normal focus of the explorer.

Please see the attached demonstration.mov
Expected behavior
My expectation coming as a vim user is:

  1. type / to begin filter
  2. type in the search
  3. hit enter and I'm in the mode where n goes to the next selection as in vim's (:help /)

Screenshots
If applicable, add screenshots to help explain your problem.
If remapping-related, please attach log output: https://github.com/VSCodeVim/Vim#debugging-remappings.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.21.5
  • VSCode version: 1.55
  • OS: max osx Big Sur 11.5.1

Additional context
Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the explorer view using the filter steps described, then trace how Enter is handled after entering a search. Confirm that Enter leaves the explorer in the expected navigation mode, where n selects the next match, rather than a greyed-out or file-renaming state.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.