block scope highlight doesn't support multiline compatability
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Issue Type: Bug
Whenever you use a block scope on VS Code (Ctrl + V) and then look for a character such as a ", the highlight only goes as far as the current line.
How to replicate
- In the following code, put the cursor at the first " instance (left side of Density)
<StringInput fullWidth disabled label="Density (kg/m³)" value={density} />
<StringInput fullWidth disabled label="Area (mm²)" value={area} />
<StringInput fullWidth disabled label="Volume (mm³)" value={volume} />
-
Ctrl + V to use block scope and then go down twice (I use
j) to go to " beside Volume -
Find the next instance of " from the Volume line (the " at the right side of )).
At this point, the block highlight should occur but even for the other lines, it would only go as far as the position of the " on the current line.
This leads to incorrect selection of characters.
Extension version: 1.20.3
VS Code version: Code 1.56.2 (054a9295330880ed74ceaedda236253b4f39a335, 2021-05-12T17:44:30.902Z)
OS version: Darwin x64 20.4.0
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600) |
| GPU Status | 2d_canvas: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled |
| Load (avg) | 2, 3, 4 |
| Memory (System) | 16.00GB (0.10GB free) |
| Process Argv | . --crash-reporter-id 0f8fe9d0-d843-4c56-947e-9a3e90b58bd9 |
| Screen Reader | no |
| VM | 0% |
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
vspre833:30267464
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
pythondataviewer:30285071
vscus158cf:30286554
vscgsv2ct:30301613
vscorehovct:30302760
bridgeflightcf:30302070
vscod805cf:30301675
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported block-scope selection in VS Code using the JSX example and the listed Ctrl+V and navigation steps. Then locate the TypeScript code handling block-scope highlighting and search across lines; done means the highlight preserves the correct per-line positions when the searched character appears at different columns.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100