Incorrect default for `ignorecase`/`smartcase`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
What did you do?
Search using / command.
What did you expect to happen?
Perform case sensitive search
What happened instead?
Performed case insensitive (+smartcase) search.
I suspect the defaults come from here
https://github.com/VSCodeVim/Vim/blob/master/src/configuration/configuration.ts#L56
But I haven't looked closely enough at the code base to know if that's true.
I personally use case sensitive search (which is the default in vim), but my real concern here is that it's inconsistent with the roadmap
You can also see the unrelated weirdness of the hlsearch row in that image.
I'm able to override the setting fine with "vim.ignorecase": false in the vscode settings, so it's just the default that I believe is wrong.
Technical details:
- VSCode Version: 1.4.0
- VsCodeVim Version: 0.1.7
- OS: Ubuntu
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/configuration/configuration.ts around line 56 and inspect the default values for ignorecase and smartcase. Reproduce a search with the / command and compare its behavior with the issue's expected Vim defaults and roadmap; done means the defaults produce case-sensitive search without requiring a user override.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- search, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100