VSCodeVim / VSCodeVim/Vim

Cursor sync with go to definition

Open
#6,352 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
The problem since this commit: https://github.com/VSCodeVim/Vim/commit/dfae9b7109e8f5349bc2e5c5789374b767a7c745
Code: https://github.com/VSCodeVim/Vim/blob/master/extensionBase.ts#L253-L264

I've found this bug with go to definition, but i'm sure there are more commands

To Reproduce

  1. Open b. Place insert cursor somewhere. Close b
  2. Open a. Insert mode. Go to definition (ctrl+click).
  3. Press any vim's key, a, i, v...
  4. See that your cursor remains in the old place

Video

https://user-images.githubusercontent.com/10743009/112668891-12edfc80-8e70-11eb-9423-28a10676c571.mov

Environment (please complete the following information):

  • Extension (VsCodeVim) version: newest
  • VSCode version: 1.54.3
  • OS: mac

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read extensionBase.ts lines 253-264 and reproduce the reported sequence with go to definition in VS Code. Check how the cursor position is handled after navigation, then verify that subsequent Vim commands act at the new cursor location rather than the old one.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.