VSCodeVim / VSCodeVim/Vim

The `<C-c>` to `<copy>` override and the `<C-d>` to `<D-d>` override should only occur after checking for remaps

Open
#5,812 0 comments 2 reactions 1 assignee View on GitHub

@berknam is already working on this.

Since Dec 3, 2020.

area/remap kind/bug
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
The <C-c> to <copy> override and the <C-d> to <D-d> override should only occur after checking for remaps so that the users can still remap this keys. Also this keys shouldn't be overridden when called by remap, only when pressed by the user.

To reproduce
Using a remap like this:

"vim.normalModeKeyBindingsNonRecursive": [
    {
        "before": ["<D-c>"],
        "after": ["<Esc>"]
    },
]

or this:

"vim.visualModeKeyBindingsNonRecursive": [
    {
        "before": ["<C-c>"],
        "after": ["<right>"]
    },
]

Doesn't work because the <D-c> and <C-c> keys are always overridden to <copy>.

Expected behavior
The remaps should still work

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.