`<C-w><C-c>` should close entire split even if multiple tabs are open in it
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
C-w C-c currently closes a single tab, only closing the split if it's the last tab in the split. It should always close the split.
To Reproduce
Steps to reproduce the behavior:
- Press
C-w C-vto open a new vertical split. - Open a second file/tab in one of the splits.
- Press
C-w C-cin that split to close the split. - It won't close, only the tab you just opened will.
Expected behavior
The split should close, even though it had 2 tabs open.
Environment (please complete the following information):
- Extension (VsCodeVim) version: v1.17.1
- VSCode version: 1.51.1
- OS: Windows_NT x64 10.0.19041
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior in VSCodeVim with C-w C-v, multiple tabs in one split, and then C-w C-c. Trace the handling of these key sequences and split/tab closing, and consider the issue done when C-w C-c closes the active split even when it contains multiple tabs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- desktop, developer-experience
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100