Use `vimState.editor` whenever possible
Open
Nobody has claimed this yet.
kind/enhancement
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
vscode.window.activeTextEditor can change when we're not looking, which I think is the cause of annoying issues such as the getLineLength out of bounds bug. By using vimState.editor in its place, we eliminate a lot of race conditions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating uses of vscode.window.activeTextEditor and compare them with the available vimState.editor context. The work is done when applicable editor access uses vimState.editor and the relevant race-condition behavior is covered by the project’s existing checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100