VSCodeVim / VSCodeVim/Vim

Opening a peek window result makes vscode-vim switch to VISUAL mode

Open
#5,491 1 comment 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug

When a peek window is open (for example peek references), I can open a particular entry by hitting Enter. This automatically closes the peek window and jumps to the code pointed to by the peek entry. However, at this point, vscode-vim switches to VISUAL mode. It's really inconvenient because now I have to hit Escape

To Reproduce
Steps to reproduce the behavior:

Created a sample Go file for reproduction:

package main

import "fmt"

func foo() {
	fmt.Println("Hello World!")
}

func main() {
	foo()

	foo()
}

While on the definition of foo, invoke Go to References from the command palette. It should show a peek window like the following:

image

Hit enter on any of the results in the peek window to jump to the code. vscode-vim at this point switches to VISUAL mode.

Expected behavior

vscode-vim should remain in NORMAL mode.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.17.1
  • VSCode version: 1.50.1
  • OS: 10.15.7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the provided Go sample: invoke Go to References, open a peek result with Enter, and observe the mode after the jump. Trace the VS Code peek-result handling and mode transition; done means opening a result leaves vscode-vim in NORMAL mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.