Bad coloring of last character in search mode
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
Since VSCodeVim 1.17, with some color themes, the cursor has a bad coloring in search mode, and is barely readable.
To Reproduce
Use a color theme like dark+ or monokai (the issue happens with both). Search for something with /. The coloring of the last character of the search is barely readable.
Expected behavior
The last character of the search should appear correctly. As per 1.16.0:
Environment (please complete the following information):
VS Code version: Code 1.49.2 (e5e9e69aed6e1984f7499b7af85b3d05f9a6883a, 2020-09-24T16:29:41.983Z)
OS version: Windows_NT x64 10.0.19042
Remote OS version: Linux x64 3.10.0-1127.18.2.el7.x86_64
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in VS Code 1.49.2 using the dark+ or monokai theme, then compare search mode with the 1.16.0 behavior shown in the report. Trace the TypeScript code responsible for rendering the final search character; done means that character is readable and matches the expected appearance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100