VSCodeVim / VSCodeVim/Vim

Use objects as poor man's keyword arguments for some functions

Open
#522 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted kind/refactor size/S
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

A couple of our functions have a few trailing boolean arguments, which makes invocations impossible to read.

Make these arguments into objects and use destructuring to improve readability.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name specific files or functions. Search the TypeScript codebase for functions with multiple trailing boolean arguments, then inspect their call sites and existing tests; done means the selected arguments are passed as objects and destructured without changing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.