VSCodeVim / VSCodeVim/Vim

"Simple" keybindings for Dvorak lead to regular crashing of vim extension - any suggestions appreciated :)

Open
#5,166 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
Ok so I was super happy to see that some headway had been made on key mappings so that I could make some small changes so I can more easily use VSCode + Vim + Dvorak. So a big thanks for all the contributors hard work to make VSCodeVim a reality.

Unfortunately something I have done leads to regular crashes of the extension. When this happens I disable and re-enable the extension and it rights itself.

Generally it crashes when I am trying to do multi-line stuff or multi-select stuff, at least I think...

To Reproduce
Steps to reproduce the behavior:

Heres my complete settings file.

Additionally I do have a few extensions installed - for different languages, but no snippets libraries or such that may conflict with vim.

{
    "todo-tree.tree.showScanModeButton": false,
    "vim.easymotion": true,
    "vim.incsearch": true,
    "vim.useSystemClipboard": true,
    "vim.useCtrlKeys": true,
    "vim.hlsearch": true,
    "vim.insertModeKeyBindings": [
        {
            "before": ["h", "h"],
            "after": ["<Esc>"]
        }
    ],
    "vim.normalModeKeyBindings": [
        {
            "before": ["h"],
            "after": ["h"]
        },
        {
            "before": ["t"],
            "after": ["j"]
        },
        {
            "before": ["n"],
            "after": ["k"]
        },
        {
            "before": ["s"],
            "after": ["l"]
        },
        {
            "before": ["H"],
            "after": ["0"]
        },
        {
            "before": ["T"],
            "after": ["L"]
        },
        {
            "before": ["N"],
            "after": ["H"]
        },
        {
            "before": ["S"],
            "after": ["$"]
        },
        {
            "before": ["j"],
            "after": ["n"]
        },
        {
            "before": ["J"],
            "after": ["N"]
        },
        {
            "before": ["k"],
            "after": ["s"]
        },
        {
            "before": ["K"],
            "after": ["S"]
        }
    ],
    "vim.visualModeKeyBindings": [
        {
            "before": ["h"],
            "after": ["h"]
        },
        {
            "before": ["t"],
            "after": ["j"]
        },
        {
            "before": ["n"],
            "after": ["k"]
        },
        {
            "before": ["s"],
            "after": ["l"]
        },
        {
            "before": ["H"],
            "after": ["0"]
        },
        {
            "before": ["T"],
            "after": ["L"]
        },
        {
            "before": ["N"],
            "after": ["H"]
        },
        {
            "before": ["S"],
            "after": ["$"]
        },
        {
            "before": ["j"],
            "after": ["n"]
        },
        {
            "before": ["J"],
            "after": ["N"]
        },
        {
            "before": ["k"],
            "after": ["s"]
        },
        {
            "before": ["K"],
            "after": ["S"]
        }
    ],
    "vim.leader": "<space>",
    "vim.handleKeys": {
        "<C-a>": false,
        "<C-f>": false
    },
    "git.enableSmartCommit": true,
    "files.autoSave": "onFocusChange",
    "window.zoomLevel": 1,
    "git.confirmSync": false,
    "codestream.email": "dan.lewis@bamboocreative.nz",
    "javascript.updateImportsOnFileMove.enabled": "always",
    "explorer.confirmDragAndDrop": false,
    "typescript.updateImportsOnFileMove.enabled": "never",
    "editor.tabSize": 2,
    "compile-hero.disable-compile-files-on-did-save-code": true
 }

Expected behavior
It just works :)

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.16.0
  • VSCode version: 1.48.2
  • OS: osx 10.15.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the crash in VSCodeVim 1.16.0 with the supplied keybindings on VSCode 1.48.2 under macOS 10.15.6, focusing on multiline and multi-select operations. Compare behavior with the listed settings and determine what consistently triggers the extension failure; done means those operations no longer regularly crash the extension.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.