Remapping of ; to ` fails when ; used as leader key
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
Remapping of ; to ` fails when ; used as leader key
To Reproduce
from settings:
"vim.leader": ";",
"vim.normalModeKeyBindingsNonRecursive": [
// workaround for vscode bug in code folding
{
"before": ["`"],
"after": [";"]
},
]
Expected behavior
` should work as vim ; ie repeat f,F,t,T motion (forward)
Environment (please complete the following information):
- Extension (VsCodeVim) version:
- VSCode version:1.16.0
Version: 1.48.1
Commit: 3dd905126b34dcd4de81fa624eb3a8cbe7485f13
Date: 2020-08-19T17:09:41.484Z (2 wks ago)
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported settings with ; as vim.leader and the non-recursive mapping from before investigating the keybinding entry points. Verify how the leader key and remapped are processed, then confirm that ` repeats Vim f, F, t, and T motions as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vim, vscode
- Domain
- developer-experience, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100