VSCodeVim / VSCodeVim/Vim

Remove or make optional regexes with lookbehinds

Open
#5,072 4 comments 1 reaction 1 assignee View on GitHub

@J-Fields is already working on this.

Since Jul 24, 2020.

system/web
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

These make the extension crash when running in some browsers:

private static readonly notEscapedSlashRegex = /(?<=[^\\])\//g;
private static readonly notEscapedQuestionMarkRegex = /(?<=[^\\])\?/g;
const regex = /(?<=^(?:~|\$HOME)).*/;

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.