Abandon `EditorIdentity` and map `TextEditor` directly to `ModeHandler`
@J-Fields is already working on this.
Since May 22, 2020.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
This is pending https://github.com/microsoft/vscode/issues/15178 , which will hopefully land in the next VS Code release. It's been put back on the backlog.
Currently, we have a ModeHandler for each TextDocument, and have to sync VS Code's selections back to VimState each time the active editor changes, because it may change between editors of the same document. This works most of the time, but should be unnecessary. One instance where it fails is syncing a visual line selection where the cursor is in the middle of the line. It also means that the mode is shared among these editors, and it's caused many other strange bugs in the past.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.