Pressing tab in file search box does not iterate through the fields
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
Pressing tab in file search box (Cmd+f) does not iterate through the fields, forcing you to use the mouse if you want to interact with the search box fields.
To Reproduce
Steps to reproduce the behavior:
Cmd+fto open the file search box- Press
tabto iterate through the fields - Notice that tab only jumps from the search input to the first button. Pressing tab further does not jump to the next buttons nor
Shift+Tabjumps back to the input field. - Also notice that if you're on the input field, pressing
Shift+Tabdoes not focus the arrow button before it to open the replace input field.
Expected behavior
I would expect the same behavior as when Vim is disabled: pressing Cmd+f opens the file search box, Shift+Tab focuses the arrow before the search input field (that opens the replace input field) and Tab focuses the next field (or button) in the sequence going all the way around.
- Extension (VsCodeVim) version: 1.13.1
- VSCode version: Insiders 1.44.0
- OS: macOS 10.15.4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Cmd+f file search behavior in VS Code with the Vim extension enabled, then compare it with Vim disabled as described. Trace the extension's keyboard and focus handling for the search and replace controls; done means Tab and Shift+Tab move through all fields and buttons in both directions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100