VSCodeVim / VSCodeVim/Vim

Go to line not working when line number pattern matches "\d0\d"

Open
#4,723 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Hi there,

Recently I've been experiencing this issue, as described in the title.

I first noticed it when I was trying to go to line 104. Hitting 1, 0, 4, G only took me to line 4, not line 104. I tried some more with 101 to 109, all behaved the same. Then I tried 120 G, this time I reached the last line, looks like as long as there's '0' involved, the behavior is disturbed. Please take a look at this.

Describe the bug

Go to line not working when line number pattern matches "\d0\d"

To Reproduce

  1. Press Esc to enter normal mode
  2. Hit 1, 0, 3, shit+g
  3. Cursor blinks at line 3 instead of line 103

Environment:

OS

MacOS Catalina 10.15.4 (19E266)

VSCode:

Version: 1.43.2
Commit: 0ba0ca52957102ca3527cf479571617f0de6ed50
Date: 2020-03-24T07:34:57.037Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0

Vim (for VSCode):

1.13.1

Please let me know if there's other information you need.

Thanks,
Li

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue identifies the normal-mode go-to-line entry point: pressing digits followed by Shift+G, with 103 reproducing the bug. Reproduce it in the VSCodeVim extension and investigate the handling of the line-number input; add or update a regression test so 103 G reaches line 103 while 3 G still reaches line 3.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.