VSCodeVim / VSCodeVim/Vim

Refactor: standardize Position bounds-checking

Open
#4,686 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/refactor
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Currently, we are haphazardly bounds-checking in various places. In some we silently correct the Position, in some we log a warning, and in some we throw an error. This should be done in a consistent way, and ideally we wouldn't have to worry about it elsewhere.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating Position and all existing bounds checks, then determine the consistent behavior and where it should be centralized. Done means the scattered handling follows one agreed policy without requiring callers to duplicate it.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.