VSCodeVim / VSCodeVim/Vim

Status Bar Colour Sticks When Modifying settings.json

Open
#4,307 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

kind/bug
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
With vim.statusBarColorControl = true, when modifying any entry in VS Code's user settings file (settings.json) from within VS Code the status bar colour will get stuck until settings.json is saved and a mode change occurs (without doing this the status bar colour will remain stuck even on restarting VS Code).

To Reproduce
Steps to reproduce the behavior:

  1. Ensure "vim.statusBarColorControl": true
  2. Open settings.json in VS Code (Preferences: Open Settings (JSON))
  3. Modify any entry (e.g. for the entry "editor.rulers": [79], replace the 79 value with 80 via a specific mode like R)

The status bar will remain bright red (default [R]eplace mode colour) due to VSCodeVim not updating the settings.json file properly with the new mode colour. This colour will then stick until settings.json is saved by the user and then another mode change occurs.

Expected behavior
Changing mode should continue to make the status bar change colour to reflect the mode change.

Environment (please complete the following information):

  • VSCode version: 1.40.2
  • OS: Windows_NT x64 10.0.18362.476 (Win 10 Pro)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in VS Code by enabling vim.statusBarColorControl, opening settings.json, and changing a value in a mode. Trace the status-bar color update triggered by mode changes and settings edits; done means the color continues to follow the current mode without requiring a save or additional mode change.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.