toggleVim and vim.disableExtension result in different behavior
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
Toggling vim.disableExtension does not change the cursor and doesn't toggle VIM: DISABLED in the status bar. It does disable vim features as expected.
To Reproduce
Steps to reproduce the behavior:
In my case, I wanted to use settings cycler to change to vim mode + some other settings at the same time.
"settings.cycle": [
{
"id": "keyMode", // must be unique
"overrideWorkspaceSettings": true,
"values": [
{
"vim.disableExtension": false,
"editor.lineNumbers": "relative",
},
{
"vim.disableExtension": true,
"editor.lineNumbers": "on",
}
]
},
],
Expected behavior
I'm expecting toggleVim and vim.disableExtension to have the same exact behavior. Both status bar and cursor need to change in both cases.
- Extension (VsCodeVim) version: 1.10.2
- VSCode version: 1.38.1
- OS: OSX 10.14.6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by comparing the existing toggleVim command with the vim.disableExtension setting change, then verify that both paths update Vim features, the cursor, and the VIM: DISABLED status bar indicator consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100