VSCodeVim / VSCodeVim/Vim

IDE crashes after pasting text objects in visual mode

Open
#3,820 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
Visual Studio crashes every time I paste text objects over a selected text.
This error does not occur with lines (e.g. yy ->Vp).
Using cmd+v instead of p (e.g. viw + cmd+v) also works fine.

To Reproduce
Steps to reproduce the behavior:

  1. Remap:
   {
      "before": [
        "p",
      ],
      "after": [
        "p",
        "g",
        "v",
        "y"
      ]
    },
  1. Yank a text object: yiw / yw / yaw
  2. Past it over a selected text: viwp /Vp, v + hjkl + p

Expected behavior
Should replace the selected word with the yanked one.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.8.1
  • VSCode version: 1.35.0 (1.35.0)
  • OS: macOS: 10.12.6

EDIT: The conflict seems to be with pgvy (which I remapped to p). Disabling it in the User Settings seems to temporarily fix the issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the crash in VSCodeVim 1.8.1 with the pgvy remapping, then compare yiw/yw/yaw followed by viwp or Vp against linewise pasting and cmd+v. Trace the visual-mode paste path and the pgvy handling; done means replacing the selected word with the yanked text without crashing while preserving the working linewise cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.