Crash caused by mapping
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Crash
VSCode stops responding
To Reproduce
- Add following mapping to settings.json:
"vim.normalModeKeyBindingsNonRecursive": [
{
"before": ["n"],
"commands": ["search.action.focusNextSearchResult"]
}
]
- Open any text file
- Ensure that there is no search results. Press "Clear search results button" button on search panel if necessary
- Focus opened file
- Press
n(the key used in step 1) - See VSCode stops responding to any clicks and key presses
Expected behavior
There is no any concrete expected behavior because search.action.focusNextSearchResult action is meaningless until search is performed, but at least VSCode is not expected to crash
Screenshots


Environment:
"Developers: Show Running Extensions" -> "Report Issue":
{
"messages": [],
"activationTimes": {
"startup": true,
"codeLoadingTime": 519,
"activateCallTime": 1,
"activateResolvedTime": 127,
"activationEvent": "*"
},
"runtimeErrors": []
}
- Issue Type:
Bug - Extension Name:
vim - Extension Version:
1.8.0 - OS Version:
Darwin x64 17.6.0 - VSCode version:
1.34.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the crash in VSCodeVim by adding the mapping in settings.json, opening a text file with no search results, and pressing n. Start by tracing the vim extension's handling of the search.action.focusNextSearchResult command. Done means the command no longer makes VSCode stop responding when no search has been performed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100