VSCodeVim / VSCodeVim/Vim

`/`, `?` and `*` search do not match every occurrence in large files

Open
#3,659 6 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/performance kind/enhancement status/by-design
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
While using /, ?, or * to search for something in a large file, many matches are skipped. It seems like it is only finding entries after my cursor position. (Depending on the size of the file, the matches may wrap around to the first part of the file.)

To Reproduce
This only seems to happen when opening a large file. In my case it is a 8000+ line log file

  1. Open the file and go somewhere in the middle of the file
  2. Using /, ? or *, search for something
  3. Only items after the cursor are highlighted and are navigated to with n and p

Expected behavior
All entries should be highlighted

Screenshots
In this instance, I had my cursor on the TRACE in line 8988 and pressed *. Only the TRACE in the next lines are highlighted, not before:

image

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.3.0
  • VSCode version: 1.33.0
  • OS: Win7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in VSCodeVim 1.3.0 with an 8000+ line log file, placing the cursor in the middle before using /, ?, or *. Check how matches are highlighted and navigated with n and p; done means every occurrence is highlighted and reachable, including entries before the cursor.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools, search
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.