Undo via `u` does not remove file dirty flag
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
Using u to undo changes doesn't restore the file to a clean state when reverting back to the original file that was opened.
To Reproduce
Steps to reproduce the behaviour:
- open file
- enter insert mode
- insert a space, observe tab has dirty icon
- exit to normal mode and press
uto remove change - File is still considered dirty
Expected behaviour
If you perform this same operation but instead of pressing u you press ctrl+z the file will return to a clean state, this should be the same for u
Environment (please complete the following information):
- Extension (VsCodeVim) version: 0.16.12
- VSCode version: 1.28.2
- OS: Ubuntu 18 LTS
Additional context
Related issue in vscode for context https://github.com/Microsoft/vscode/issues/919
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the sequence in VSCode 1.28.2 with VSCodeVim 0.16.12, comparing u with ctrl+z and observing the file's dirty indicator. The issue is done when undoing the inserted space with u restores the file to a clean state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100