VSCodeVim / VSCodeVim/Vim

Text expansion utilities don’t work correctly

Open
#2,818 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

BUG REPORT:
When using a text expansion utility (Breevy on Windows 10), the text used to trigger the expansion is not replaced correctly. This has a related open issue on https://github.com/Microsoft/vscode/issues/51510, but in my case this problem is VSCodeVim specific, and disabling VSCodeVim seems to solve it.

I tried changing the settings of VSCodeVim in user settings to find what could be causing it, but I was unable to find anything that solved this issue. Any ideas what in VSCodeVim could be causing it (so I can test disabling it in the user settings)?

What happened:

  • writing "l " expanding to "land"
  • writing "tiia " expanding to "tiiathis i"

What did you expect to happen:
Writing "l " expanding to "and " (without the text used to trigger the expansion (in this case the letter l followed by the trigger " " (space)). Also note that the backspace to remove "l" instead removes the space after "and"

Writing "tiia " expanding to "this is a"
Same problem, and shows the problem of the expansion being triggered prior to the removal of the text used to trigger the expansion, and the subsequent backspaces backspace

How to reproduce it (as minimally and precisely as possible):
see
https://github.com/Microsoft/vscode/issues/51510

Environment:

  • Extension Name: vim
  • Extension Version: 0.14.2
  • OS Version: Windows_NT x64 10.0.16299
  • VSCode version: 1.25.0
  • Breevy version 3.37

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No repository files or tests are named. Start by reproducing the Breevy expansion behavior with VSCodeVim 0.14.2, VS Code 1.25.0, and the linked VS Code issue; done means the trigger text is removed and the expanded text and following backspace behavior match the expected examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.