vim_navigateRight doesn't recognise panel on the right side
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
BUG REPORT
What happened:
I use keybindings to navigate between tabs, panels and the sidebar. I used the keybindings.json setup from #2376, so that I can use ctrl+h/k/j/l to navigate.
I moved the integrated terminal to the right.
ctrl+l (extension.vim_navigateRight) cannot navigate to the integrated terminal on the right hand side.
Unexpectedly, ctrl+j (extension.vim_navigateDown) can focus it.
It seems that it doesn't recognise that I moved the integrated terminal to right.
What did you expect to happen:
extension.vim_navigateRight can navigate to the integrated terminal on the right hand side.
extension.vim_navigateDown should not navigate to the integrated terminal on the right hand side.
How to reproduce it (as minimally and precisely as possible):
- Open integrated terminal, and move it to right
- Focus on the editor and press
ctrl+l, it won't navigate. - However, press
ctrl+jcan navigate to the terminal.
Environment:
- Extension (VsCodeVim) version: 0.11.3
- VSCode version: 1.21.1
- OS version: macOS 10.13.3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the extension.vim_navigateRight and extension.vim_navigateDown command handlers, then reproduce the setup with the integrated terminal moved to the right. Check how each command determines panel position; done means right-side terminals are reached with navigateRight and not navigateDown, while the existing editor and sidebar navigation remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100