VSCodeVim / VSCodeVim/Vim

[Help Wanted] dont konw how to bind `closeMarkersNavigation`

Open
#2,402 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/remap
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

What happened: a specified key-binding not working

What did you expect to happen: close marker popup with my shortcut

How to reproduce it (as minimally and precisely as possible):

Environment:

  • Extension (VsCodeVim) version: 0.11.0
  • VSCode version: 1.20.1
  • OS version: macOS High Sierra 10.13.3

I create some mapping for non-edit mode to navigation lint errors.

     "vim.leader": "<space>",
    "vim.otherModesKeyBindingsNonRecursive": [
        {
            "before": [
                "<leader>",
                "e",
                "n"
            ],
            "commands": [
                {
                    "command": "editor.action.marker.next"
                }
            ]
        },
        {
            "before": [
                "<leader>",
                "e",
                "p"
            ],
            "commands": [
                {
                    "command": "editor.action.marker.prev"
                }
            ]
        },
        {
            // not working
            "before": [
                "<leader>",
                "e",
                "c"
            ],
            "commands": [
                {
                    "command": "closeMarkersNavigation"
                }
            ]
        }
    ],

The prev and next binding works good. But closeMarkersNavigation do nothing while marker popup can be closed by pressing shift+escape which is default key-binding of vscode:
image

I try change command to editor.action.closeMarkersNavigation and workbench.closeMarkersNavigation, both failed too.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No repository file or test is named. Start by comparing VS Code's default Shift+Escape keybinding with the command identifiers accepted by vim.otherModesKeyBindingsNonRecursive, then inspect how VSCodeVim forwards those commands. Done means a configured mapping closes the marker popup using the correct command identifier.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.