VSCodeVim / VSCodeVim/Vim

IndentObject should use linewise mode

Open
#2,313 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/bug
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Starting file:

a
|    a
a

Keys pressed: viiyp

Expected result:

a
     a
    |a
a

Actual result:

a
 |    a
   a
a

Instead of putting the yanked text below the current line, VSCodeVim puts it after the cursor. I think this is because ii doesn't use linewise mode.

This happens with all <operator>ii, <operator>ai, and <operator>aI. For example, yiip fails in the same way.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported viiyp, yiip, and related operator-plus-text-object sequences using the starting file and compare the resulting cursor and text placement with the expected output. Trace the handling of ii, ai, and aI through the extension's text-object and paste behavior; done means these combinations paste below the current line in linewise mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.