`list.toggleExpand` can't coexist with `explorer.openToSide` under Vim
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG
What happened:
{
"key": "o",
"command": "list.toggleExpand",
"when": "listFocus && !inputFocus"
},
// @FIXME "explorer.openToSide" is Not Working with same key.
{
"key": "o",
"command": "explorer.openToSide",
"when": "filesExplorerFocus && !listFocus && !inputFocus"
},
What did you expect to happen:
list.toggleExpand can coexist with explorer.openToSide using same key map under different conditions.
How to reproduce it (as minimally and precisely as possible):
Update keybindings.json with key maps settings listed above.
Environment:
- Extension (VsCodeVim) version: v0.10.7
- VSCode version: v1.20.0-Insider
- OS version: macOS High Sierra v10.13.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the behavior from keybindings.json with the two mappings and the listed VS Code and VSCodeVim versions. Verify whether both commands work under their stated conditions, then identify the relevant VSCodeVim entry point or tests; done means the same key triggers list.toggleExpand and explorer.openToSide in their respective contexts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100