VSCodeVim / VSCodeVim/Vim

'Find' in VISUAL MODE reverts to first occurrence when looping through them

Open
#2,238 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/search help wanted kind/bug
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Environment:

  • VSCode Version: 1.19.0
  • VsCodeVim Version: Sunny Seattle
  • OS: Ubuntu 17.10

What happened:
When navigating through occurrences of Find in file that was initiated with VISUAL MODE, cursor goes back to first occurrence whenever find popup is closed.

What did you expect to happen:
Cursor should stay at current occurrence upon exiting Find in file.

How to reproduce it:

  1. Select chunk of text (e.g. const) with multiple occurrences in file with v (mode switches to VISUAL).
  2. Press Ctrl+f. Find popup appears with const in it.
  3. Navigate through occurrences with Enter.
  4. Press Esc on desired occurrence to close find popup and expect the cursor to stay on this occurrence.
  5. See the cursor going back to first occurrence where it was in step 1.
  6. Cry.

Example
screenshot

Here Find started at first const, I've navigated to third one with Enter. When I press Esc to exit Find, cursor goes back to first const though should stay at third one.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in VSCodeVim by entering Visual mode, opening Find with Ctrl+F, navigating with Enter, and closing it with Esc. Trace the Visual-mode Find handling and cursor restoration; done means the cursor remains on the selected occurrence after the popup closes, with the behavior covered by a regression test if the existing test setup supports it.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
desktop, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.