Change handleKeys to take a `mode`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
- Click thumbs-up 👍 on this issue if you want it!
- Click confused 😕 on this issue if not having it makes VSCodeVim unusable.
The VSCodeVim team prioritizes issues based on reaction count.
Is this a BUG REPORT or FEATURE REQUEST?: Feature request
Changing handleKeys to take a mode (INSERT, NORMAL, VISUAL, etc) would allow greater customization and control over when vsc or vim should handle key events.
See #2056 as an example.
In normal mode pressing <C-w> would close the current file, window, etc. but in insert mode would delete a word backwards.
Note: The behavior of <C-w> vs db are slightly different. I can elaborate more if necessary.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the handleKeys implementation and its callers in the VSCodeVim TypeScript codebase, then review issue #2056 for the referenced example. Trace how INSERT, NORMAL, and VISUAL modes are represented and how key events are currently routed. Done means handleKeys can receive the relevant mode and the described Ctrl-W behavior can be customized per mode without breaking existing mappings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- developer-experience, devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100