Add support for when clause in commands
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
- Click thumbs-up 👍 on this issue if you want it!
- Click confused 😕 on this issue if not having it makes VSCodeVim unusable.
The VSCodeVim team prioritizes issues based on reaction count.
FEATURE REQUEST:
Support "when" in custom binding commands. This will allow one to create toggle commands that do different things based on the state of the editor.
For example:
"vim.otherModesKeyBindingsNonRecursive": [
{
"before": ["-"],
"commands": [
{
"command": "workbench.files.action.focusFilesExplorer",
"when": "editorFocus",
"args": []
},
{
"command": "workbench.action.toggleSidebarVisibility",
"when": "explorerViewletFocus",
"args": []
}
]
}
]
Pressing - while focused on an editor, shows and sets focus to the file explorer. Pressing - in the file explorer, closes the explorer sidebar and sets you back into the editor.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how VSCodeVim parses and executes custom binding commands, using the example configuration as the behavioral reference. Verify that command entries can be selected by their when conditions, then test the toggle behavior in both editor focus and file explorer focus.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100