VSCodeVim / VSCodeVim/Vim

Undo in Settings while changing vim.statusBarColors breaks the plugin

Open
#2,025 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


BUG REPORT

Environment:

  • VSCode Version: 1.15
  • VsCodeVim Version: 0.10.0
  • OS: Win 10

What happened:

Playing around with statusBarColors, I tried to go back to the last color after saving the settings file.
In the meantime, the automated colorCustomizations had already loaded, being undone instead and then auto-generated again.
I hit u a few times until I noticed, then escape a few times. Now this file is in a state where I cannot finish the current command. After closing the file and reopening (same vs code session), the command stack (see photo) is still there.

image

What did you expect to happen:
Esc should cancel whatever command I'm typing

How to reproduce it:
I guess hitting u and saving a lot while changing the status bar colors. Maybe some copy+paste, too.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior in the settings file while changing statusBarColors, saving repeatedly, and using undo, u, and Escape. Inspect the command stack shown in the report and compare the state before and after closing and reopening the file. Done means Escape reliably cancels the current command and reopening the file does not preserve a stuck command state.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.