VSCodeVim / VSCodeVim/Vim

Unrecognised ex-commands changes indentation

Open
#1,948 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/bug
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Environment:

  • VSCode Version: 1.14.2
  • VsCodeVim Version: 0.9.0
  • OS: Ubuntu Gnome 17.04

I have vim.enableNeovim enabled.

What happened:
When I write a command that (I imagine) isn't supported, the 4 space indentation in my Python code is turned into tabs and the bottom right of VS Code where it shows the indentation you're using is switched from "Spaces: 4" to "Tabs: 4". Even something that I thought should work, didn't: :%s/verticies/vertices/g
After a little experimenting, apparently anything the command bar doesn't recognise causes this behaviour, for example :asd

What did you expect to happen:
When writing :%s/verticies/vertices/g, I expected it to replace all instances of 'verticies' with 'vertices'.
When writing :asd, I expected a message saying it's not a recognised command.

How to reproduce it:
Open a Python source file that uses spaces for indentation, ensure your editor says "Spaces: 4" in bottom right, then open the command bar by pressing : and write anything that isn't an actual command and hit enter and observe that what was "Spaces: 4" has turned into "Tabs: 4" and indentation is now in tabs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce this in a Python file using spaces, then trace the command-bar handling for an unrecognised ex-command such as :asd or the substitution example. Confirm where the editor indentation mode changes; done means unsupported commands report an error without converting spaces to tabs, while supported substitutions retain their expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.