VSCodeVim / VSCodeVim/Vim

Problems interacting with k--kato/vscode-docomment

Open
#1,742 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

I first thought, this is just a small bug of the other extension and tried to fix it k--kato/vscode-docomment#46
When pasting comments the addon will think you entered a new comment and add another one to it.

In the review you can see, that my fix does not work, due to a big problem:

  • we can not already inserted text as a measurement for whether this is a new insert or not, since the current implementation relies on that as well
  • we do not have a possibility to get the state of vscodevim afaik

Do we have a possibility to tell another addon, that this was an insertion (via state) or just marking the whole action as a "paste" action?
Can we stop the addon queue from triggering after an insert?
Do i miss some clever way on distinguishing between the 2 cases?

Environment:

  • VSCode Version: 1.12.2
  • VsCodeVim Version: 0.7.1
  • OS: Linux Mint

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the interaction between VSCodeVim and k--kato/vscode-docomment, using the versions and Linux Mint environment listed in the issue. Review k--kato/vscode-docomment#46 and the described insertion, paste, and addon-queue behavior; done means pasted comments no longer produce an extra comment while normal insertions still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.