VSCodeVim / VSCodeVim/Vim

args not being passed to otherModesKeyBindingsNonRecursive runTask command

Open
#1,693 1 comment 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/feature
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


BUG REPORT

Environment:

  • VSCode Version: 1.12.1
  • VsCodeVim Version: 0.7.1
  • OS: OSX 10.11.6

What happened:
I set up my settings as follows:

    "vim.leader": "<space>",
    "vim.otherModesKeyBindingsNonRecursive": [
        {
            "before": ["leader", "e"],
            "after": [],
            "commands": [
                {
                    "command": "workbench.action.tasks.runTask",
                    "args": ["tsc"]
                }
            ]
        }
    ]

I then press <space> + e

The task palette comes up, allowing me to choose the tsc task (which I can do by typing tsc or arrowing down and pressing enter)

What did you expect to happen:
I expect the editor to run the tsc task without additional user input

How to reproduce it:
See above...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the configuration for vim.otherModesKeyBindingsNonRecursive and the workbench.action.tasks.runTask command. Trace the keybinding command execution to determine where the args are lost; done means pressing the mapped keys runs the tsc task directly without showing the task picker.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.