otherModesKeyBindingsNonRecursive interferes with built-in terminal

• Click thumbs-up 👍 on this issue if you want it!
• Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.

BUG REPORT

Environment:

• VSCode Version: 1.12.1
• VsCodeVim Version: 0.7.1
• OS: macOS Sierra (10.12.3)

What happened:

I have the following settings to toggle the file explorer

"vim.leader": "<space>",
"vim.otherModesKeyBindingsNonRecursive": [
        {
            "before": ["<leader>", "e"],
            "commands": [
                {
                    "command": "workbench.action.toggleSidebarVisibility"
                }
            ]
        }
]

which doesn't allow <space> to be pressed in the built-in terminal, rendering the terminal basically useless.

What did you expect to happen:

That the above key binding should not interfere in the terminal because the terminal is basically 'insert mode' and thus this binding should not apply.

How to reproduce it:

Set the above settings and press <space> in the terminal. Instead of entering a space character, the message (Space) was pressed. Waiting for second key of chord... appears

No source files or tests are named. Start by tracing where vim.otherModesKeyBindingsNonRecursive is handled and how the built-in terminal is identified; reproduce the configured , e sequence there. Done means the terminal accepts a space while the binding continues to work in applicable non-insert modes.