Limit infinite recursion in macros
Open
Nobody has claimed this yet.
kind/enhancement
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
What did you do?
Accidentally wrote a macro with an infinite loop
Put the exact keys you pressed.
qqiexampletextEscq@q
What did you expect to happen?
Expected the macro definition to fail and @q to remain undefined
What happened instead?
Macro got into an infinite loop and required a vscode restart
Technical details:
- VSCode Version: 1.9.1
- VsCodeVim Version: 0.5.2
- OS: 10.12.3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by reproducing the exact macro keys, qqiexampletextEscq@q, in the reported VSCode and VsCodeVim versions, then trace macro execution until the recursion occurs. Done means an infinite macro no longer requires a VSCode restart and @q remains undefined as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100