`:w` doesn't save unchanged file
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Please thumbs-up 👍 this issue if it personally affects you! You can do this by clicking on the emoji-face on the top right of this post. Issues with more thumbs-up will be prioritized.
So sometimes I trigger my tools to run by resaving files without having changed them (typically to run tests in guard). In Vim :w will cause this to happen, in VsCodeVim it presumably checks the file's dirty state before saving. Sounds logical on paper, but is a bit inconvenient for me in practise.
What did you do?
:w on unchanged file.
What did you expect to happen?
My file watcher tools to run.
What happened instead?
Nothing. (File was not updated)
Technical details:
- VSCode Version: 0.9.0
- VsCodeVim Version: 0.5.2
- OS: OSX Sierra
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the TypeScript command handling for :w, then reproduce the behavior with an unchanged file and a watcher such as guard. Done means saving an unchanged file triggers the watcher as it does in Vim, with coverage for this case in the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100