VSCodeVim / VSCodeVim/Vim

`k` motion goes to wrong line when in line visual mode with cursor above selection

Open
#10,008 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

While in line visual mode with the cursor above the selection start, the k motion goes to the wrong line (it computes the destination relative to the bottom of the selection, when it should be relative to the top). Introduced in fd2b7e80; reverting that commit appears to fix it for me.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the k motion in line visual mode with the cursor above the selection, then inspect commit fd2b7e80 to trace how the destination line is calculated. Done means k resolves relative to the top of the selection rather than the bottom, with the behavior verified against the reported scenario.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.