VEuPathDB / VEuPathDB/study-wrangler
`entity_from_file` should handle completely empty lines in the input file
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 0
- Forks
- 0
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 1
Description
After #87 and the skip_empty_rows=FALSE configuration change for read_tsv and read_csv it seems like we only handle empty rows with delimiters, e.g. ,,,,,,
We should add test cases with completely empty lines (not testable with entity_from_tibble it will need to be part of entity_from_file) and fix this.
Problem file
plas-phenotype_test_true maptxt.txt
Cleaned file (from csvclean)
plas-phenotype_test_true maptxt_out.csv
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the entity_from_file entry point and review how it uses read_tsv and read_csv after the skip_empty_rows=FALSE change. Add entity_from_file test cases using the provided problem file or equivalent completely empty lines, then verify that empty rows are handled correctly without relying on entity_from_tibble.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100