VEuPathDB / VEuPathDB/study-wrangler

Confirm collections display_range behaviour

Open
#40 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
0
Forks
0
Avg merge
2d 1h
Merged PRs (30d)
1

Description

Current behaviour is

  1. no display_range_min or max provided anywhere -> display_range for collection remains unset, range_min and range_max are calculated from the data as usual (min(range_min) and max(range_max) over child vars)
  2. display_range provided for one or more collection and/or child vars -> display_range calculated as the widest range of all provided display_ranges (min(display_range_min) and max(display_range_max) over collection annotations and child vars)

Thus in this example:
VarA: display_range 0 to 100
VarB: display_range 0 to 100
VarC: no display_range set, actual data ranges -5 to +5

The collection's display range will be 0 to 100. However, this is a dubious collection that should not be made in the first place.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Inspect the collection and child-variable display_range handling and existing tests first, then determine whether the documented range calculation is intended. Done means the expected behavior is confirmed or an explicit change is scoped and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.