VEuPathDB / VEuPathDB/study-wrangler

Provide no-ID column guidance in `inspect(entity)`

Open
#10 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
R
Stars
0
Forks
0
Avg merge
2d 1h
Merged PRs (30d)
1

Description

The advice given in validate(entity) when there's no ID column:

> validate(genePhenotype)
Validation issues found:
This entity appears to have no ID column.
It must have a column with a unique value in each row.
You can create a simple numeric ID as follows:
  genePhenotype <- genePhenotype %>%
    modify_data(mutate(ID = row_number())) %>%
    sync_variable_metadata() %>%
    redetect_column_as_id('ID')
Then `validate(genePhenotype)` again

Should also be provided by inspect()

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementations of validate(entity) and inspect(entity), then read how validate() formats the no-ID diagnostic shown in the issue. Update inspect() so it provides equivalent no-ID guidance, and verify that inspecting an entity without an ID column displays the instructions.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.