VEuPathDB / VEuPathDB/WDK

Add validation to IDs included in dataset params

Open
#47 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1
Forks
4
Avg merge
1m
Merged PRs (30d)
1

Description

Overview

We've recently had invalid files uploaded as dataset parameters in our WDK sites. These have not been rejected in validation, causing issues downstream. We would like to add basic validation to ensure IDs are restricted to the following characters:

  • [0-9]
  • [a-zA-Z]
  • .
  • -
  • _
  • :
  • (
  • )

We could alternatively wire up a regex parameter in the WDK model, though this would be a more considerable effort.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the Java validation entry point for dataset parameters, then inspect how uploaded IDs are checked. Done means IDs containing characters outside digits, letters, '.', '-', '_', ':', '(' and ')' are rejected before they reach downstream processing.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.