Feature request: Add redirectUrl query parameter support to `/service/logout` endpoint
A pull request for this has already been merged.
- #123 by @ryanrdoherty — merged
- Dominant language
- Java
- Stars
- 1
- Forks
- 4
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
For the delete account button work (https://github.com/VEuPathDB/web-monorepo/pull/1493) it would be great if the /service/logout also took a redirectUrl query parameter (like login already does). Currently it seems not to, and always redirects to the homepage on success.
We will be redirecting to a /a/app/user/message/account-deleted route, to give a bit more feedback to the user.
I'll need to check that this page reliably works for guest users. Not sure at the moment (though this is not in the scope of this ticket!)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by locating the /service/logout endpoint and comparing its redirect handling with the existing login endpoint's redirectUrl support. Done means logout accepts the parameter and redirects to the requested URL instead of always using the homepage; check the linked pull request for existing work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100