UniversalMediaServer / UniversalMediaServer/api

Make sure we aren't storing failure docs for TMDB connection problems

Open
#702 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
12
Forks
3
Avg merge
16d 31m
Merged PRs (30d)
6

Description

Can be done in the service like we do for OMDb by throwing ExternalAPIError. I haven't verified it is a problem but it's an idea.

We could add logging and look at their docs to see what HTTP statuses they return

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by finding the TMDB service and comparing its failure handling with the existing OMDb service that throws ExternalAPIError. Check TMDB's documented HTTP statuses and add logging only if needed to verify connection failures. Done means connection-failure responses are not stored as failure documents and the behavior is covered by the relevant checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
mongodb, nodejs, typescript
Domain
api, backend, database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.