Unity-Technologies / Unity-Technologies/com.unity.webrtc

[BUG]: Video resolution with odd numbered size is resized unintendedly

Open
#731 12 comments 0 reactions 1 assignee View on GitHub

@karasusan is already working on this.

Since May 18, 2022.

bug issued
Dominant language
Assembly
Stars
852
Forks
238
PR merge metrics
No merged PRs in 30d

Description

Package version

2.4.0-exp.7

Environment
* OS:Windows 10
* Unity version:2019.4
Steps To Reproduce
  1. establish a stream between android and Windows, including video
  2. call ReplaceTrack on the video track on Android, including a size change
  3. observe on Windows that UnityVideoRenderer.OnVideoFrameResize does not get called on Windows
Current Behavior

OnVideoFrameResize doesn't get called, but only on Windows. ReplaceTrack with a new video track of the same size continues to stream. Changing the video stream on Windows, the OnVideoFrameResize call happens on Android.

Expected Behavior

Windows should also receive the callback from the c++ side.

Anything else?

This is a new issue, not found in 2.4.0-exp6.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.