Unity-Technologies / Unity-Technologies/NativeRenderingPlugin
Is there a missing #include <d3d11.h> in IUnityGraphicsD3D11.h ?
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 943
- Forks
- 186
- PR merge metrics
- No merged PRs in 30d
Description
I wasn't sure if this was intentional or if I'm missing something but, I just had my code break when an autoformatter sorted my headers, which made my #include <d3d11.h> get declared after IUnityGraphicsD3D11.h, leading to lots of unknown type errors
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open IUnityGraphicsD3D11.h and check whether its declarations require types from d3d11.h before that header is included. Reproduce the reported header-order failure with d3d11.h included afterward; done means the header works in that order without unknown type errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100