Unity-Technologies / Unity-Technologies/NativeRenderingPlugin

[Vulkan] Crash if vulkan render plugin is preloaded

Open
#42 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
943
Forks
186
PR merge metrics
No merged PRs in 30d

Description

It seems like this line in Hook_vkGetInstanceProcAddr should return vkGetInstanceProcAddr(device, funcName); instead of NULL
Because will NULL return editor is crashing on start, and no initialization is done.

https://github.com/Unity-Technologies/NativeRenderingPlugin/blob/d6d6f993e7b98731745a7ea5482e46fde01a5ce3/PluginSource/source/RenderAPI_Vulkan.cpp#L115

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at PluginSource/source/RenderAPI_Vulkan.cpp:115 in Hook_vkGetInstanceProcAddr and review the linked source context around the current NULL return. Verify that preloading the Vulkan render plugin no longer crashes the Unity editor on startup and that initialization occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, unity
Domain
computer-graphics
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.