Unity-Technologies / Unity-Technologies/NativeRenderingPlugin

Multisamples issues in Vulkan

Open
#27 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
943
Forks
186
PR merge metrics
No merged PRs in 30d

Description

In Vulkan when creating pipelines, the sample count must be indicated in VkPipelineMultisampleStateCreateInfo. The pipeline can't be later used with a rendertarget with a different sample count.

A native plugin doesn't receive information about the sample count of the current active render pass. I think this could be added to UnityVulkanRecordingState.

Note that the Vulkan example provided in this repository has hardcoded the sample count and doesn't work with cameras using MSAA.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with RenderAPI_Vulkan.cpp around the hardcoded sample count at line 388 and inspect UnityVulkanRecordingState. Trace how the active render pass state reaches native plugins, then verify the Vulkan example works with cameras using MSAA and differing sample counts.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.